28 Nov
2022
28 Nov
'22
12:28 p.m.
Jacek Caban (@jacek) commented about dlls/wininet/tests/http.c:
+ ok(res, "HttpSendRequest failed: %lu\n", GetLastError()); + if(!res) goto abort; + + size = 0; + while(size < BUFFER_SIZE) { + res = InternetReadFile(hor, expect_response+size, BUFFER_SIZE-size, &count); + if(!res || !count) + break; + size += count; + } + ok(size, "InternetReadFile returned no content\n"); + if(!size) goto abort; + + if(hor) InternetCloseHandle(hor); + if(hic) InternetCloseHandle(hic); + if(hi) InternetCloseHandle(hi); Those if()s are redundant.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1268#note_17654