9 Nov
2023
9 Nov
'23
1:56 p.m.
On Thu Nov 9 12:46:16 2023 +0000, Giovanni Mascellani wrote:
This seems correct, but it's overall quite confusing. I'd rather use something like `toggle_ordered ? SpvOpFOrdEqual : SpvOpFUnordEqual`, which is hardly more code, but it's easier to understand. Thinking again, I'd even introduce opcodes with explicit orderedness rather than a flag. Ternary operators is what I had originally, but I changed it to the bit flip because it seemed clearer to me. Yes this probably calls for new opcodes and the renaming of existing ones.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/441#note_51706