Re: [PATCH v23 0/4] MR4661: gdiplus: Implement Gdiplus effects

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c:
> +
> +    if (effect->type == RedEyeCorrectionEffect)
> +    {
> +        if ((paramsize-size > 0) || (((size-paramsize)%sizeof(RECT)) != 0))
> +            return InvalidParameter;
> +    }
> +    else
> +    {
> +        if (paramsize != size)
> +            return InvalidParameter;
> +    }
> +
> +    if (!effect->params)
> +        effect->params = malloc(size);
> +    else
> +        effect->params = realloc(effect->params, size);
> The if statement is not needed, `realloc` works in both cases.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_59202