24 Jan
2024
24 Jan
'24
3:29 a.m.
Zhiyi Zhang (@zhiyi) commented about dlls/iphlpapi/tests/iphlpapi.c:
id = GetCurrentThreadCompartmentId(); ok(id == NET_IF_COMPARTMENT_ID_PRIMARY, "got %u\n", id); } +//Test passes no parameters of importance but returns error if size passed into +//GetAdaptersAddresses is zero and is Ok if the returned value is ERROR_INVALID_PARAMETER +static void test_GetAdaptersAddressesSizeZeroParamReturnInvalidParameterError(void)
Rename to test_GetAdaptersAddresses(). And then add your specific tests with comments about what it's testing for exactly. Instead of putting the description in the function name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4926#note_58762