Re: [PATCH v3 0/4] MR2587: Support MF DXGI device manager in h264 decoder

6 Apr 2023


      Rémi Bernon (@rbernon) commented about dlls/winegstreamer/h264_decoder.c:
...
goto failed;
     if (FAILED(hr = MFCreateVideoSampleAllocatorEx(&IID_IMFVideoSampleAllocatorEx, (void **)&decoder->allocator)))
         goto failed;
+    if (FAILED(hr = MFCreateSampleCopierMFT(&decoder->copier)))
+        goto failed;
*ret = &decoder->IMFTransform_iface;
     TRACE("Created decoder %p\n", *ret);
     return S_OK;
failed:
You're still missing a release for the allocator here. Other than that I think it looks good.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2587#note_29199