24 Apr
2023
24 Apr
'23
2:22 p.m.
On Mon Apr 24 09:57:42 2023 +0000, Jacek Caban wrote:
Those constructors are just error-prone, I think it could be better to just move AddRefs to constructors. I wanted to avoid it because there's too much boilerplate as-is for each constructor, now will be even more…
I agree it's error prone. Are you still against the idea of storing as much as possible in a data table instead? Including compatibility mode like this, so it wouldn't be part of the constructor at all. The reason I liked it was that it would reduce the amount of boilerplate copy pasted code in each constructor. Or are you still against it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2691#note_31002