Re: [PATCH 0/7] MR106: vkd3d-shader/hlsl: packoffset() support.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
> hlsl_error(ctx, &loc, VKD3D_SHADER_ERROR_HLSL_INVALID_MODIFIER,
>                  "Parameter '%s' is declared as both \"out\" and \"uniform\".", param->name);
>
> -    if (!(var = hlsl_new_var(ctx, param->name, param->type, loc, ¶m->semantic, param->modifiers, ¶m->reg_reservation)))
> +    if (param->offset_reservation.type)
> +        hlsl_error(ctx, &loc, VKD3D_SHADER_ERROR_HLSL_INVALID_RESERVATION,
> +            "packoffset() is only allowed inside constant buffer declarations.");

We don't have a test for this, right?

(Also, 8-space indentation).

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106#note_25670