Re: [PATCH v8 0/7] MR564: vkd3d-shader/ir: Transform clip/cull signature elements into an array.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
> result = instruction_array_normalise_hull_shader_control_point_io(instructions,
>                  &parser->shader_desc.input_signature);
>      }
> -    if (result >= 0)
> -        result = shader_normalise_io_registers(parser);
> +    if (result < 0)
> +        return result;

Agreed, I was about to send something similar too. I think there is room for improvement here too, though. How would you see this?
```c
    if (parser->shader_version.type != VKD3D_SHADER_TYPE_PIXEL)
    {
        if ((result = remap_output_signature(parser, compile_info)) < 0)
            return result;
    }

    if (parser->shader_version.type == VKD3D_SHADER_TYPE_HULL)
    {
        if ((result = instruction_array_flatten_hull_shader_phases(instructions)) < 0)
            return result;

        if ((result = instruction_array_normalise_hull_shader_control_point_io(instructions,
                &parser->shader_desc.input_signature)) < 0)
            return result;
    }
```

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564#note_57887