Re: [PATCH 0/3] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_muxer.c:
> +
> +            gst_event_parse_segment(event, &segment);
> +            if (segment->format != GST_FORMAT_BYTES)
> +            {
> +                pthread_mutex_unlock(&muxer->mutex);
> +                GST_FIXME("Unhandled segment format \"%s\".", gst_format_get_name(segment->format));
> +                break;
> +            }
> +            muxer->offset = segment->start;
> +
> +            pthread_mutex_unlock(&muxer->mutex);
> +            break;
> +
> +        default:
> +            GST_WARNING("Ignoring \"%s\" event.", GST_EVENT_TYPE_NAME(event));
> +            break;
> This seems unrelated to the buffers being pushed, and instead something that will be triggered by pushing the segment? Maybe it should be split?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3810#note_45162