Re: [PATCH v3 0/5] MR8905: mshtml: Implement toJSON() for Performance* objects.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/omnavigator.c:
> +    HRESULT hres;
> +    VARIANT v;
> +
> +    TRACE("(%p)->(%p)\n", This, var);
> +
> +    if(!This->window->jscript)
> +        return E_UNEXPECTED;
> +
> +    if(!var)
> +        return S_OK;
> +
> +    hres = IWineJScript_CreateObject(This->window->jscript, &json);
> +    if(FAILED(hres))
> +        return hres;
> +
> +    hres = dispex_builtin_props_to_json(&This->navigation->dispex, This->window, &v);
> Why not just `IHTMLPerformanceNavigation_toJSON(This->navigation, &v)`? You wouldn't need to change stored type then.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8905#note_115354