11 Jul
2025
11 Jul
'25
6:10 p.m.
Connor McAdams (@cmcadams) commented about dlls/setupapi/tests/devinst.c:
err = GetLastError(); ok(!err, "Expect last error %#x, got %#lx\n", ERROR_SUCCESS, err); ok(keys_len == required_len, "%lu != %lu\n", keys_len, required_len); - ok(keys_len >= expected_keys, "Expected %lu >= %lu\n", keys_len, expected_keys); + ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, (DWORD)ARRAY_SIZE(expected_keys));
```suggestion:-0+0 ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %u\n", keys_len, ARRAY_SIZE(expected_keys)); ``` Casting this feels a bit funky, I'd just do the above instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109601