30 Sep
2025
30 Sep
'25
2:58 a.m.
Nikolay Sivov (@nsivov) commented about dlls/mfreadwrite/writer.c:
+ entry = &stream->converter; + break; + default: + LeaveCriticalSection(&writer->cs); + return MF_E_INVALIDINDEX; + } + + if (!entry->transform) + { + LeaveCriticalSection(&writer->cs); + return MF_E_INVALIDINDEX; + } + + IMFTransform_AddRef((*transform = entry->transform)); + if (category) + *category = entry->category; Category GUIDs are fixed, so if we know for sure that you can only have one encoder and one converter at most, we can simply return corresponding constants here.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7570#note_117140