18 Nov
2022
18 Nov
'22
12:25 a.m.
Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_parser.c:
} gst_object_unref(stream->my_sink);
+ if (stream->buffer) + { + gst_buffer_unmap(stream->buffer, &stream->map_info); + gst_buffer_unref(stream->buffer); + stream->buffer = NULL; + } +
Maybe. The awkward thing here is that the code currently assumes we'll *always* call wg_parser_stream_release_buffer() if we got a buffer, which makes this redundant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1278#note_16276