On Mon Mar 2 11:08:40 2026 +0000, Alexandre Julliard wrote:
I'm getting test failures locally (but not on the CI), is that expected? ``` cfgmgr32.c:1802: Test succeeded inside todo block: test_cases[0]: device L"\\\\?\\DISPLAY#BNQ7954#0000&0000#{E6F07B5F-EE97-4A90-B076-33F57BF4EAA7}": got len2 1 cfgmgr32.c:1813: Test succeeded inside todo block: test_cases[0]: device L"\\\\?\\DISPLAY#BNQ7954#0000&0000#{E6F07B5F-EE97-4A90-B076-33F57BF4EAA7}": failed to get object using query filters ``` There was some property casing logic change, as going through setupapi modified the DeviceInstance property in the registry to uppercase, whereas the code now only reads the registry property, as keeps the casing it had. This made the tests to fail if the property wasn't always uppercase and I had added a todo for that, but in your case the device instance value was already uppercase.
I changed the test logic to make sure we compare the values case insensitively. The setupapi code needs to be fixed but that'll be done by changing it to use cfgmgr32. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10204#note_130896