11 May
2025
11 May
'25
3:10 p.m.
On Sun May 11 15:09:59 2025 +0000, Matteo Bruni wrote:
I'd have written this more naturally (to me) as: ```suggestion:-1+0 if ((ck_channel < color_key->color_key_min[i]) || (ck_channel > color_key->color_key_max[i])) break; ``` But maybe I'm missing something? I've spent awhile trying to come up with an explanation for doing it the way I did, and nothing came to mind. In a prior iteration I had this check done in a separate function, and I _feel_ like that had something to do with it, although even then I can't come up with a reason why it would've made sense :) I've changed it to the way you've done it here, it makes more sense.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7711#note_102945