Re: [PATCH v18 0/5] MR820: Implement application hives

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about server/registry.c:
> +        if ((filename = malloc( req_data_len + 1 )))
> +        {
> +            memcpy( filename, req_data, req_data_len );
> +            filename[req_data_len] = 0;
> +
> +            if (req->flags & REG_APP_HIVE)
> +                reply->hkey = load_app_registry( key, filename, req->access, objattr->attributes );
> +            else
> +                load_registry( key, filename );
> +
> +            free( filename );
> +        }
> +        else
> +            set_error( STATUS_NO_MEMORY );
> +
>          release_object( key );
> I suspect that it would be cleaner to have a separate request for loading app keys.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_9747