Re: [PATCH v8 0/6] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> +    {
> +        WARN("Function target value is not a function declaration.\n");
> +        vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> +                "Function call target value is not a function declaration.");
> +        return;
> +    }
> +
> +    if (!type)
> +    {
> +        type = fn_value->type->u.pointer.type;
> +    }
> +    else if (type != fn_value->type->u.pointer.type)
> +    {
> +        WARN("Explicit call type does not match function type.\n");
> +        type = fn_value->type->u.pointer.type;
> +    }
> Not a big deal, but this seems to be more readable:
if (type != fn_value->type->u.pointer.type)
    WARN("Explicit call type does not match function type.\n");
type = fn_value->type->u.pointer.type;

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283#note_42474