Re: [PATCH v6 0/2] MR2471: winegstreamer: In video_processor, activate a videoflip converter.

[eric pouech (＠epo)]

On Fri Apr 14 06:46:21 2023 +0000, Zebediah Figura wrote:
> This doesn't look right at all. If nothing else, this shouldn't be
> touching wmvcore.
> Why is mf_media_type_to_wg_format_video() wrong as-is?
> If I understand the tests correctly, wmvdecode, color convert and video processor don't handle the MF_MT_DEFAULT_STRIDE attribute (or its absence) the same way
|                 |      |     | MF output format | MF output format w/ | MF output format w/ |
|                 | From | To  | w/o stride       | positive stride     | negative stride     |
|-----------------+------+-----+------------------+---------------------+---------------------|
| decode          | WMV  | YUV | no flip          | no flip             | no flip             |
| decode          | WMV  | RGB | flip             | flip                | flip                |
| color conv      | YUV  | RGB | no flip          | no flip             | flip                |
| video processor | YUV  | RGB | flip             | no flip             | flip                |

So I tried to keep in mf_media_type_to_wg_format_video() what's look generic, and moved to each wg_transform() callers the specific handling.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2471#note_30033