20 Jul
2024
20 Jul
'24
1:24 a.m.
Fabian Maurer (@DarkShadow44) commented about dlls/shell32/enumobjects.c:
+ + IUnknown_AddRef((IUnknown*)*obj); + return S_OK; +} + +/************************************************************************** + * IEnumObjects_fnAddRef + * + * See IUnknown_AddRef. + */ +static ULONG WINAPI IEnumObjects_fnAddRef(IEnumObjects *iface) +{ + IEnumObjectsImpl *This = impl_from_IEnumObjects(iface); + ULONG refCount = InterlockedIncrement(&This->ref); + + TRACE("(%p)->(%lu)\n", This, refCount - 1); I think we normally trace the refcount as is. Also, AFAIK camelcase is discouraged.
Same for Release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_76700