28 Nov
2022
28 Nov
'22
5:57 p.m.
Piotr Caban (@piotr) commented about dlls/msvcrt/tests/file.c:
close (fd);
+ fd = open ("fdopen.tst", O_RDONLY, _S_IREAD |_S_IWRITE); + errno = 0xdeadbeef; + ok(dup2(fd, -1) == -1, "dup2 succeeded on read-only file\n");
dup2 is failing because second argument is -1, not because it's a read-only file. ```suggestion:-0+0 ok(dup2(fd, -1) == -1, "dup2(fd, -1) succeeded\n"); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1553#note_17702