Re: [PATCH 0/1] MR591: winhttp: Avoid invalid memory access in netconn_resolve().

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/winhttp/net.c:
> +{
> +    struct async_resolve *ret;
> +
> +    if (!(ret = malloc(sizeof(*ret))))
> +    {
> +        ERR( "No memory.\n" );
> +        return NULL;
> +    }
> +    ret->ref = 1;
> +    ret->hostname = strdupW( hostname );
> +    ret->port     = port;
> +    if (!(ret->done = CreateEventW( NULL, FALSE, FALSE, NULL )))
> +    {
> +        free( ret );
> +        return NULL;
> +    }
> This leaks ret->hostname on error. Ideally we'd use GetAddrInfoExW() here but the timeout parameter is not supported yet.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/591#note_5710