On Sun Feb 19 12:45:05 2023 +0000, **** wrote:
Gabriel Ivăncescu replied on the mailing list: ``` On 19/02/2023 02:14, Etaash Mathamsetty (@etaash.mathamsetty) wrote:
Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/cfgmgr32/main.c:
+ +#include "wine/debug.h" +#include "cfgmgr32.h" + +WINE_DEFAULT_DEBUG_CHANNEL(cfgmgr32); + +/*********************************************************************** + * CM_MapCrToWin32Err (cfgmgr32.@) + */ +CMAPI DWORD WINAPI CM_MapCrToWin32Err( CONFIGRET code, DWORD default_error ) +{ + TRACE( "code: %ld, default_error: %ld\n", code, default_error ); + + switch (code) + { + case CR_SUCCESS: return ERROR_SUCCESS; nitpick: maybe indent this? (and the rest of the switch case)
Do you mean the case? It's usually preference, and Wine code is either of them, but I personally think it's better to not have it indented, it creates unnecessary indentation levels. Anyway this is opinion based. ``` I think the preferred style in Wine is to not indent it.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2231#note_24939