11 Dec
2024
11 Dec
'24
6:22 p.m.
Nikolay Sivov (@nsivov) commented about dlls/msxml3/element.c:
if (!node->nsDef) return S_FALSE;
- attrIndex++; ns = node->nsDef; + if (!ns->next) + attrIndex++; for (; attrIndex < index && ns->next != NULL; attrIndex++) ns = ns->next;
This is a bit hard to read. Can we maybe incorporate that in loop conditions somehow instead of doing sort of unroll of the first iteration? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6993#note_90282