18 Feb
2025
18 Feb
'25
9:41 p.m.
Thanks, cursory review looks good now. For the record—while "tests before fix" is generally a good practice, I would argue that it's not always necessary, and especially not necessary when it's not a fix but a new feature. In such cases I'd advocate for putting the implementation first, or if it's simple enough (like here) squash them together even. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7216#note_95057