On Tue Dec 2 09:42:59 2025 +0000, Alexandre Julliard wrote:
There's no twaindsm.dll by default on Windows, so the tests won't do anything. We should keep them in twain_32. Am Dienstag, dem 02.12.2025 um 03:43 -0600 schrieb Alexandre Julliard (@julliard):
Alexandre Julliard commented on a discussion on dlls/twaindsm/tests/dsm.c: https://gitlab.winehq.org/wine/wine/-/merge_requests/9519#note_124385
> return; > } > > - htwain = LoadLibraryA("twain_32.dll"); > + htwain = LoadLibraryA("twaindsm.dll"); > if (! htwain) > { > - win_skip("twain_32.dll not available, skipping tests\n"); > + win_skip("twaindsm.dll not available, skipping tests\n");
There's no twaindsm.dll by default on Windows, so the tests won't do anything. We should keep them in twain_32.
I assume you want to keep the comparison what the code does on native Windows? But when associating the tests with twain_32.dll, which only exists on 32-Bit Windows, the tests would only test something in 32-Bit Windows and would not do anything in 64-Bit Windows and ARM platforms. Should we posibly add test code both for twaindsm and for twain_32, initially the same code just with different dll names? As Esme suggested? Or just do something like #ifdef WIN64 htwain = LoadLibraryA("twaindsm.dll"); #else htwain = LoadLibraryA("twain_32.dll"); #endif And try using the PARENTSRC feature? Bernd Herd :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9519#note_124434