8 Jun
2024
8 Jun
'24
11:51 a.m.
On Sat Jun 8 11:51:09 2024 +0000, Jinoh Kang wrote:
It has ~100 changed lines (excluding tests) across 8 commits, which is hard to review at a glance. Would you move test commits prior to fix commits? The test commits will introduce `todo_wine` before `ok()`s expected to fail, and fix commits will remove them. That would make it easier to understand what fixes what. There's the only single test commit, and it's already a separate one. Remaning patches don't introduce new tests.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5665#note_72781