30 May
2023
30 May
'23
6:44 p.m.
On Tue May 30 14:12:22 2023 +0000, Huw Davies wrote:
Since the current implementation uses the key in token_enum I would have to re-stub the current implementation in order to split the second commit. Would this be a good idea? No, that would cause a regression. Couldn't you add the changes to `TokenEnumBuilder` without changing `token_category_EnumTokens()` in the first instance? Unfortunately not, since the new tokens array replaces the HKEY stored originally in `token_enum`. The old implementation of `EnumTokens` uses this HKEY: https://gitlab.winehq.org/wine/wine/-/merge_requests/2905/diffs?commit_id=43... .
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2905#note_34149