27 Nov
2022
27 Nov
'22
5:09 a.m.
Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_parser.c:
pthread_mutex_lock(&parser->mutex);
+ if (!stream->has_tags) + { + /* If we receieved a buffer waiting for tags in wg_parser_connect() does not make sense anymore. */ + stream->has_tags = TRUE; + pthread_cond_signal(&parser->init_cond); + } +
Lowercase "true". I think it'd be mildly clearer to use a separate variable "has_buffer" and check e.g. "has_buffer || has_tags" in wg_parser_connect(), but I don't feel strongly about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1542#note_17590