14 Nov
2023
14 Nov
'23
7:10 p.m.
Gabriel Ivăncescu (@insn) commented about dlls/mshtml/mshtml_private.h:
ret = malloc(size + 1); if(ret) { if(len) WideCharToMultiByte(CP_UTF8, 0, str, len, ret, size, NULL, NULL); - ret[size] = '\0'; + ret[size] = '\0';
The `ret[size] = '\0'` statement is **not** part of the if condition, so adding indentation to it should *actually* cause a warning. Can you post the warning? This sounds like a compiler bug to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4391#note_52263