5 Feb
2026
5 Feb
'26
9:33 p.m.
On Thu Feb 5 21:28:15 2026 +0000, Brendan Shanks wrote:
If we use `CreateIconFromResourceEx()`, doesn't that mean that Wine decompresses the PNG, then we have to draw it into a CGImage? These are typically Vista icons, so 256x256 or larger. `create_cgimage_from_icon()` and `create_cgimage_from_icon_bitmaps()` are also not simple functions. It seems preferable to just give the PNG to macOS when that's possible. Ha :) I just put up a CreateIconFromResourceEx version. I liked unifying the path, and since it's a one-time operation, the round-tripping didn't bother me. But I definitely understand skipping the HICON-ification. :shrug: Either way strikes me as acceptable.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10036#note_128914