Giovanni Mascellani (@giomasce) commented about tests/reflect.shader_test:
+uniform float2 i; +uniform float4 n; + +float4 main() : sv_target +{ + return reflect(i, n); +} + +[pixel shader fail] +uniform float3 i; +uniform float2 n; + +float4 main() : sv_target +{ + return reflect(i, n); +} These two are slightly misleading. The call to `reflect()` is totally fine, the test fails because it cannot convert `float2` to `float4` when returning.
I am attaching the tests as I fixed them, which probably better pinpoint the behavior of `reflect()`: ``` [pixel shader] uniform float4 i; uniform float4 n; float4 main() : sv_target { return reflect(i, n); } [test] uniform 0 float4 0.5 -0.1 0.2 0.3 uniform 4 float4 0.6 0.4 -0.3 1.0 draw quad probe all rgba (-0.1, -0.5, 0.5, -0.7) 4 [pixel shader] uniform float4 i; uniform float4 n; float4 main() : sv_target { float i1 = i.x; return reflect(i1, n); } [test] uniform 0 float4 0.5 0.0 0.0 0.0 uniform 4 float4 0.6 0.4 -0.3 1.0 draw quad probe all rgba (-0.52, -0.18, 1.01, -1.2) 4 [pixel shader] uniform float4 i; uniform float4 n; float4 main() : sv_target { float n1 = n.x; return reflect(i, n1); } [test] uniform 0 float4 0.5 -0.1 0.2 0.3 uniform 4 float4 0.6 0.0 0.0 0.0 draw quad probe all rgba (-0.148, -0.748, -0.448, -0.348) 4 [pixel shader] uniform float4 i; uniform float4 n; float4 main() : sv_target { float i1 = i.x; float n1 = n.x; return reflect(i1, n1); } [test] uniform 0 float4 0.5 0.0 0.0 0.0 uniform 4 float4 0.6 0.0 0.0 0.0 draw quad probe all rgba (0.14, 0.14, 0.14, 0.14) 4 [pixel shader] uniform float4 i; uniform float4 n; float4 main() : sv_target { float2 i1 = i.xy; return float4(reflect(i1, n), 0.0, 0.0); } [test] uniform 0 float4 0.5 -0.1 0.0 0.0 uniform 4 float4 0.6 0.4 -0.3 1.0 draw quad probe all rgba (0.188, -0.308, 0.0, 0.0) 4 [pixel shader] uniform float4 i; uniform float4 n; float4 main() : sv_target { float3 i1 = i.xyz; float2 n1 = n.xy; return float4(reflect(i1, n1), 0.0, 0.0); } [test] uniform 0 float4 0.5 -0.1 0.2 0.0 uniform 4 float4 0.6 0.4 0.0 0.0 draw quad probe all rgba (0.188, -0.308, 0.0, 0.0) 4 ``` The reason why in some tests I declare a `float4` uniform and then use only some components is that if I declare a `float` uniform the layout might change between SM1 and SM4. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/80#note_24535