6 Mar
2024
6 Mar
'24
6:19 a.m.
On Wed Mar 6 06:18:22 2024 +0000, Yuxuan Shui wrote:
Hmm, i think the clearer version does have a use-after-free problem. If the item is freed in `queue_cancel_item` while `scheduled_item_cancelable_callback`/`waiting_item_cancelable_callback` is running, the latter will use-after-free. I am afraid my original version is still the only way to do this. @zhiyi do you have thoughts? since you have worked on this part of code just recently? ~~Or maybe we can put the whole callback into critical section~~ I don't think this would help.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_63642