12 Apr
2023
12 Apr
'23
9:59 a.m.
```diff + if (reg->idx[2].offset != ~0u) + { + FIXME("Cannot insert phase id.\n"); + return false; + } ```
We have enough existing FIXMEs in vkd3d-shader that I won't block this series for it, but please note that as a rule vkd3d-shader should use vkd3d_shader_error() and its variants to report this kind of issue to the user of the API, instead of using FIXME and/or ERR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141#note_29721