14 May
2025
14 May
'25
9:05 a.m.
Jacek Caban (@jacek) commented about tools/widl/metadata.c:
buf->offset += size; }
+static void generate_guid( GUID *guid ) +{ + int fd = open( "/dev/urandom", O_RDONLY ); + if (fd != -1) read( fd, guid, sizeof(*guid) ); + close( fd ); +}
This is problematic both for reproducible builds and for the Windows widl build (used by mingw toolchains). I don’t know enough about the context to suggest concrete alternatives, would using a hash of other input data make sense for generating this GUID? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8037#note_103285