Re: [PATCH v2 0/13] MR1447: mshtml: Implement performance.timing timestamps properly.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/omnavigator.c:
> if(!This->timing) {
>          HTMLPerformanceTiming *timing;
>
> +        if(!This->window)
> +            return E_UNEXPECTED;
> +
>          timing = heap_alloc_zero(sizeof(*timing));
>          if(!timing)
>              return E_OUTOFMEMORY;
>
> timing->IHTMLPerformanceTiming_iface.lpVtbl = &HTMLPerformanceTimingVtbl;
>          timing->ref = 1;
> +        timing->window = This->window;
> +        IHTMLWindow2_AddRef(&timing->window->base.IHTMLWindow2_iface);

This is crating a circular reference.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1447#note_16697