22 Jul
2023
22 Jul
'23
7:35 p.m.
Esme Povirk (@madewokherd) commented about dlls/uiautomationcore/uia_com_client.c:
- if (!elem || !handler) - return E_POINTER; - - if (event_id == UIA_AutomationFocusChangedEventId) - return E_INVALIDARG; - - hr = IUIAutomationEventHandler_QueryInterface(handler, &IID_IUnknown, (void **)&handler_iface); - if (FAILED(hr)) - return hr; - element = impl_from_IUIAutomationElement9((IUIAutomationElement9 *)elem); hr = UiaGetRuntimeId(element->node, &runtime_id); if (FAILED(hr)) { - IUnknown_Release(handler_iface); + IUnknown_Release(handler_unk); I don't think this Release has a matching AddRef anymore?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3362#note_39836