Re: [PATCH v3 0/6] MR9275: jscript: Semi-implement Typed Arrays.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/arraybuf.c:
> +    hres = init_dispex(&prototype->dispex, ctx, info, ctx->object_prototype);
> +    if(FAILED(hres)) {
> +        jsdisp_release(&prototype->buffer->dispex);
> +        free(prototype);
> +        return hres;
> +    }
> +
> +    hres = create_builtin_constructor(ctx, func, name, &TypedArrayConstr_info, PROPF_CONSTR|1, &prototype->dispex, &ctx->typedarr_constr[type_idx]);
> +    jsdisp_release(&prototype->dispex);
>      if(FAILED(hres))
>          return hres;
>
> -    hres = create_builtin_constructor(ctx, func, name, &TypedArrayConstr_info, PROPF_CONSTR|1, prototype, &ctx->typedarr_constr[type_idx]);
> -    jsdisp_release(prototype);
> +    hres = jsdisp_define_data_property(ctx->typedarr_constr[type_idx], L"BYTES_PER_ELEMENT", 0,
> +                                       jsval_number(typed_array_descs[type_idx].size));
> Please move "BYTES_PER_ELEMENT" to a separate commit.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9275#note_120838