On Fri Sep 15 08:57:27 2023 +0000, Alexandre Julliard wrote:
Sort of, basically just pass the info class to the function and call it twice. Ok... to do that we will need a helper to set `ReplaceIfExists`. It is a `BOOL` for `FileRenameInformation` but a flag: `FILE_RENAME_REPLACE_IF_EXISTS` in `Flags` for `FileRenameInformationEx`. That should be ok.
The most sticky issue is that all the `FileRenameInformationEx` tests have to be marked `todo_wine` until `FileRenameInformationEx` support is submitted. Is it possible to conditionally mark a test `todo_wine`? I wasn't aware that it was. Now, I have patches for an initial `FileRenameInformationEx` implementation ready to go. In that case, if we submit that patch first, then we won't have any differing `todo_wine`s between the two classes. I understood it was preferable to submit tests before implementation, but if you will accept the test after the implementation there won't be a problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3836#note_45540