Re: [PATCH 0/6] MR543: wined3d: Cache the output mode lists where possible.

[Zebediah Figura]

On 7/26/22 20:51, Zhiyi Zhang (@zhiyi) wrote:
> Zhiyi Zhang (@zhiyi) commented about dlls/wined3d/directx.c:
> > /* FIXME: GetAdapterModeCount and EnumAdapterModes currently only returns modes
> >        of the same bpp but different resolutions                                  */
> >
> > -static bool mode_matches_filter(const DEVMODEW *mode, const struct wined3d_format *format,
> > -        enum wined3d_scanline_ordering scanline_ordering)
> > +static void wined3d_output_update_modes(struct wined3d_output *output)
> >   {
> > -    if (mode->dmFields & DM_DISPLAYFLAGS)
> > +    struct wined3d_display_mode *wined3d_mode;
> > +    unsigned int i;
> > +    DEVMODEW mode;
> > +
> > +    output->mode_count = 0;
> > +
> > +    for (i = 0; EnumDisplaySettingsExW(output->device_name, i, &mode, 0); ++i)
> > DEVMODEW.dmSize and DEVMODEW.dmDriverExtra is not initialized before calling EnumDisplaySettingsExW().

Thanks for catching that; resent.