9 Jun
2023
9 Jun
'23
8:41 a.m.
Huw Davies (@huw) commented about dlls/winealsa.drv/alsa.c:
return ret; }
+static NTSTATUS alsa_main_loop(void *args) +{ + struct main_loop_params *params = args; + NtSetEvent(params->event, NULL); + return STATUS_SUCCESS; +}
I'm sorry to sound like a broken record, but could we please make non-trivial changes to the driver in separate commits to merging code into mmdevapi? To reiterate: it would help a lot for both review purposes and any future regression searches if the driver functions look essentially identical before we merge them together. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35242