9 Nov
2023
9 Nov
'23
7:45 p.m.
Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.c:
"The '%s' target profile is incompatible with the 'dxbc-tpf' target type.", profile->name); return VKD3D_ERROR_INVALID_ARGUMENT; } + else if (compile_info->target_type == VKD3D_SHADER_TARGET_FX && profile->type != VKD3D_SHADER_TYPE_EFFECT) + { + vkd3d_shader_error(message_context, NULL, VKD3D_SHADER_ERROR_HLSL_INCOMPATIBLE_PROFILE, + "The '%s' target profile is incompatible with the 'fx' target type.", profile->name); + return VKD3D_ERROR_INVALID_ARGUMENT; + }
We also need to check the inverse here. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443#note_51762