11 Apr
2023
11 Apr
'23
5:23 p.m.
Nikolay Sivov (@nsivov) commented about dlls/shell32/ebrowser.c:
- if(!pfs) + if (!pfs) return E_INVALIDARG;
- This->fs.ViewMode = pfs->ViewMode; - This->fs.fFlags = pfs->fFlags | FWF_NOCLIENTEDGE; + if (pfs->ViewMode) + This->fs.ViewMode = pfs->ViewMode; + This->fs.fFlags = pfs->fFlags;
- /* Change the settings of the current view, if any. */ - return change_viewmode(This, This->fs.ViewMode); + if (!This->psv) + return E_INVALIDARG; + + hr = IShellView_QueryInterface(This->psv, &IID_IFolderView2, (void *)&view); This one should use void**.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2628#note_29623