Re: [PATCH v18 0/4] MR4661: gdiplus: Implement Gdiplus effects

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c:
> TRACE("(%p,%p,%u)\n", effect, params, size);
>
> -    if(!(calls++))
> -        FIXME("not implemented\n");
> +    if (!effect || !params || !size)
> +        return InvalidParameter;
>
> -    return NotImplemented;
> +    if (GdipGetEffectParameterSize(effect, ¶msize) != Ok)
> +        return InvalidParameter;
> +
> +    if (effect->type == RedEyeCorrectionEffect)
> +    {
> +        if ((paramsize-size > 0) || (((size-paramsize)%sizeof(RECT)) != 0))
> +            return InvalidParameter;

I don't think we can use `paramsize` in this case because it will depend on whether parameters were already set.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58436