Re: [PATCH 0/6] MR606: Constant buffer reflection

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-utils/reflection.c:
> compile_info.next = &reflection->signature_info;
>      reflection->signature_info.type = VKD3D_SHADER_STRUCTURE_TYPE_SCAN_SIGNATURE_INFO;
>
> -    return hresult_from_vkd3d_result(vkd3d_shader_scan(&compile_info, NULL));
> +    reflection->signature_info.next = &reflection->buffer_info;
> +    reflection->buffer_info.type = VKD3D_SHADER_STRUCTURE_TYPE_SCAN_D3D_BUFFER_INFO;
> +
> +    if (FAILED(hr = hresult_from_vkd3d_result(vkd3d_shader_scan(&compile_info, NULL))))
> +        return hr;
> +
> +    if (!(reflection->buffers = vkd3d_calloc(reflection->buffer_info.buffer_count, sizeof(*reflection->buffers))))

It doesn't look like this allocation is freed anywhere.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/606#note_59610