20 Oct
2023
20 Oct
'23
3:48 p.m.
On Fri Oct 20 15:42:41 2023 +0000, Nikolay Sivov wrote:
Regarding tests, it's becoming unmanageable in my opinion, all these stubs with different paths. It's fine to have tests diff squashed and attached here for reference, and not included with a fix. That's once you can confirm that Begin() call part is correct. I agree, I think they are useful for testing more cases like this though, but it's hard to find a way to make them more manageable. Should I just push the fix removing the tests and attach the diff for them?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3789#note_49413