Re: [PATCH v2 0/7] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/propsys/propvar.c:
> case VT_R8:
>          CMP_NUM_VALUE(dblVal);
>          break;
>      case VT_BSTR:
>      case VT_LPWSTR:
>          /* FIXME: Use other string flags. */
>          if (flags & (PVCF_USESTRCMPI | PVCF_USESTRCMPIC))
> -            res = lstrcmpiW(propvar1->bstrVal, propvar2_converted->bstrVal);
> +            res = wcsicmp(propvar1->bstrVal, propvar2_converted->bstrVal);
>          else
> -            res = lstrcmpW(propvar1->bstrVal, propvar2_converted->bstrVal);
> +            res = wcscmp(propvar1->bstrVal, propvar2_converted->bstrVal);
>          break;

Let's keep it as it is. It's not clear if STRCMPIC and STRCMP should do the same thing to begin with, and there are more flags.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6640#note_84547