Re: [PATCH 0/5] MR9089: d3dx10: Add partial support for D3DX10_IMAGE_LOAD_INFO structure fields.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
> +    }
> +
> +    /* Check behavior of the FirstMipLevel argument. */
> +    for (i = 0; i < 2; ++i)
> +    {
> +        if (i && D3DX10_SDK_VERSION == 33)
> +        {
> +            skip("FirstMipLevel argument is broken in version 33.\n");
> +            continue;
> +        }
> +
> +        winetest_push_context("FirstMipLevel %u", i);
> +        memset(&img_info, 0, sizeof(img_info));
> +        set_d3dx10_image_load_info(&load_info, D3DX10_DEFAULT, D3DX10_DEFAULT, D3DX10_DEFAULT, i, D3DX10_FROM_FILE,
> +                D3D10_USAGE_DEFAULT, D3DX10_DEFAULT, D3DX10_DEFAULT, D3DX10_DEFAULT, D3DX10_DEFAULT, D3DX10_DEFAULT,
> +                D3DX10_DEFAULT, &img_info);
> I find this a bit confusing; the general intent is clear (testing FirstMipLevel) but still it looks kinda messy. Explicitly initializing the load info structure would be a step forward I think.

It's a style matter, so certainly not a blocker or anything.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9089#note_117570