Re: [PATCH v4 0/1] MR8852: ntdll: Zero aligned size in initialize_block().

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/heap.c:
> }
>
> +static BOOL check_win_version(int min_major, int min_minor)
> +{
> +    HMODULE hntdll = GetModuleHandleA("ntdll.dll");
> +    NTSTATUS (WINAPI *pRtlGetVersion)(RTL_OSVERSIONINFOEXW *);
> +    RTL_OSVERSIONINFOEXW rtlver;
> +
> +    rtlver.dwOSVersionInfoSize = sizeof(RTL_OSVERSIONINFOEXW);
> +    pRtlGetVersion = (void *)GetProcAddress(hntdll, "RtlGetVersion");
> +    pRtlGetVersion(&rtlver);
> +    return rtlver.dwMajorVersion > min_major ||
> +           (rtlver.dwMajorVersion == min_major &&
> +            rtlver.dwMinorVersion >= min_minor);
> +}
> +#define is_win8_plus() check_win_version(6, 2)
> Please avoid version checks in tests. If absolutely necessary, check some feature of that platform instead.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8852#note_114436