Re: [PATCH v4 0/1] MR1414: ntdll: Add integration with Linux FAT file attributes

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/file.c:
> -    else
> -    {
> -        if (errno == ENOTSUP) return ret;
> -#ifdef ENODATA
> -        if (errno == ENODATA) return ret;
> +#ifdef HAVE_LINUX_MSDOS_FS_H
> +    /* try retrieving FAT file attributes */
> +    get_fat_dos_attrib( path, attr );
>  #endif
> -        WARN( "Failed to get extended attribute " SAMBA_XATTR_DOS_ATTRIB " from \"%s\". errno %d (%s)\n",
> -              path, errno, strerror( errno ) );
> -    }
> +
> +    /* try retrieving DOS attributes from extended attributes */
> +    get_xattr_dos_attrib( path, attr );
> +
> Same here, why try both methods?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1414#note_18132