12 Sep
2024
12 Sep
'24
8:31 a.m.
On Thu Sep 12 08:23:17 2024 +0000, Rémi Bernon wrote:
It does the same thing, I don't think it matters and alpha_bits is initialized with -1 everywhere else it's used. Using ~0 makes it very tempting to use ~0u, which is wrong in various cases (`UINT64 bla = ~0u`, isn't the same value as `UINT64 bla = ~0` / `UINT64 bla = -1` which both are equal). Of course it's the same thing, hence the suggestion. It's clearly wrong to assign a signed value to a variable of an unsigned type.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6482#note_82001